Add matplotlib import guards to tutorials 11 and 12#161
Merged
Conversation
Tutorials 11 (Imputation DiD) and 12 (Two-Stage DiD) called plot_event_study() without the try/except ImportError matplotlib guard pattern used by all other tutorials. Added HAS_MATPLOTLIB guard to cell 1 imports and wrapped plot calls in cell 5. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Overall assessment: ✅ Looks good Executive Summary
Methodology
Code Quality
Performance
Maintainability
Tech Debt
Security
Documentation/Tests
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
try/except ImportErrormatplotlib guard to cell 1 of tutorials 11 (Imputation DiD) and 12 (Two-Stage DiD)plot_event_study()calls in cell 5 of both tutorials withif HAS_MATPLOTLIB:guardMethodology references (required if estimator / math changes)
Validation
jupyter nbconvert --execute— all cells passSecurity / privacy
Generated with Claude Code